Skip to content

fix(linux): add a lock to PipeWire DMA-BUFs to avoid unexpected buffer overwrite and flicker - #5498

Open
happyme531 wants to merge 3 commits into
LizardByte:masterfrom
happyme531:codex/fix-pipewire-dmabuf-lifetime
Open

fix(linux): add a lock to PipeWire DMA-BUFs to avoid unexpected buffer overwrite and flicker#5498
happyme531 wants to merge 3 commits into
LizardByte:masterfrom
happyme531:codex/fix-pipewire-dmabuf-lifetime

Conversation

@happyme531

@happyme531 happyme531 commented Aug 11, 2026

Copy link
Copy Markdown

Description

  • Added a lock to the pipewire capture buffer, to avoid Kwin overwriting the content of this buffer when we are reading it, causing the video stream to flicker intermittently.
  • The lock is correctly released after we made a copy of its content or on error.
  • Only implemented for CUDA/NVENC, since this is the only device I have.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher ReenigneArcher added the ai PR has signs of heavy ai usage (either indicated by user or assumed) label Aug 12, 2026
@ReenigneArcher

Copy link
Copy Markdown
Member

Thank you for the PR submission, but it looks like you used AI to create this PR.

Please read and follow our Contributing guidelines and specifically our AI Usage policy.

Additionally, please update the PR to use the correct template. You can find it at https://github.com/LizardByte/.github/blob/master/.github/pull_request_template.md?plain=1

@happyme531 happyme531 changed the title fix(linux): retain PipeWire DMA-BUFs through CUDA conversion fix(linux): add a lock to PipeWire DMA-BUFs to avoid unexpected buffer overwrite and flicker Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai PR has signs of heavy ai usage (either indicated by user or assumed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants